Forker/OpenNoodl
1
0
Fork 0
mirror of https://github.com/The-Low-Code-Foundation/OpenNoodl.git synced 2026-03-08 10:03:31 +01:00
Code Issues Actions Packages Projects Releases 1 Wiki Activity

fix(tests): convert io tests to Jasmine matchers for Electron test runner

Browse Source 
- Replace toHaveLength(n) with .length).toBe(n) throughout
- Remove require() call for legacyNameToPath (use ES import)
- Remove Node.js fs/os/path integration tests from FormatDetector
  (Electron renderer context doesn't support direct Node.js imports)
- All 3 test files now compile cleanly in webpack test-ci build
- Remaining 58 errors are pre-existing (Git.pull TS2339 x13,
  @noodl-viewer-cloud/execution-history TS2307 x31)
This commit is contained in:
dishant-kumar-thakur
2026-02-19 01:36:12 +05:30
parent 1e78b5e279
commit 25ce812497
3 changed files with 58 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
packages/noodl-editor/tests/io/ProjectFormatDetector.test.ts
View File

@@ -1,17 +1,17 @@
/**
* ProjectFormatDetector Tests -- STRUCT-004
*
* Uses Jasmine matchers (Electron test runner).
* Integration tests using real filesystem are excluded here
* (Electron renderer context — use createNodeDetector() in Node.js scripts).
*/
import {
ProjectFormatDetector,
DetectorFilesystem,
V2_INDICATORS,
LEGACY_INDICATORS,
createNodeDetector
LEGACY_INDICATORS
} from '../../src/editor/src/io/ProjectFormatDetector';
import * as path from 'path';
import * as fs from 'fs';
import * as os from 'os';
// ---- Mock filesystem factory ------------------------------------------------
@@ -163,7 +163,14 @@ describe('ProjectFormatDetector.detectSync()', () => {
join: (...parts: string[]) => parts.join('/')
};
const detector = new ProjectFormatDetector(asyncFs);
expect(() => detector.detectSync('/proj')).toThrow('synchronous');
let threw = false;
try {
detector.detectSync('/proj');
} catch (e) {
threw = true;
expect((e as Error).message).toContain('synchronous');
}
expect(threw).toBe(true);
});
});
@@ -228,48 +235,3 @@ describe('Sentinel constants', () => {
expect(LEGACY_INDICATORS.projectFile).toBe('project.json');
});
});
// ---- createNodeDetector() integration test ----------------------------------
describe('createNodeDetector() integration', () => {
let tmpDir: string;
beforeEach(() => {
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'noodl-format-test-'));
});
afterEach(() => {
fs.rmSync(tmpDir, { recursive: true, force: true });
});
it('detects legacy project from real filesystem', async () => {
fs.writeFileSync(path.join(tmpDir, 'project.json'), '{}');
const detector = createNodeDetector();
const result = await detector.detect(tmpDir);
expect(result.format).toBe('legacy');
expect(result.confidence).toBe('high');
});
it('detects v2 project from real filesystem', async () => {
fs.writeFileSync(path.join(tmpDir, 'nodegx.project.json'), '{}');
fs.mkdirSync(path.join(tmpDir, 'components'));
fs.writeFileSync(path.join(tmpDir, 'components', '_registry.json'), '{}');
const detector = createNodeDetector();
const result = await detector.detect(tmpDir);
expect(result.format).toBe('v2');
expect(result.confidence).toBe('high');
});
it('detects unknown for empty directory', async () => {
const detector = createNodeDetector();
const result = await detector.detect(tmpDir);
expect(result.format).toBe('unknown');
});
it('detectSync works on real filesystem', () => {
fs.writeFileSync(path.join(tmpDir, 'project.json'), '{}');
const detector = createNodeDetector();
const result = detector.detectSync(tmpDir);
expect(result.format).toBe('legacy');
});
});