Forker/OpenNoodl
1
0
Fork 0
mirror of https://github.com/The-Low-Code-Foundation/OpenNoodl.git synced 2026-01-11 14:52:55 +01:00
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Fix: Javascript node error logs (#14)

Browse Source 
In some cases the error is a string, and when logging it will write "undefined" into the console instead of providing a useful error message.
This commit is contained in:
Eric Tuvesson
2024-05-09 14:09:37 +02:00
committed by Richard Osborne
parent 908ad18451
commit 62d545d4f9
3 changed files with 27 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/noodl-viewer-react/src/nodes/std-library/javascript.js
View File

@@ -1,8 +1,8 @@
'use strict';
const Node = require('@noodl/runtime').Node,
JavascriptNodeParser = require('@noodl/runtime/src/javascriptnodeparser');
const Node = require('@noodl/runtime').Node;
const JavascriptNodeParser = require('@noodl/runtime/src/javascriptnodeparser');
const { logJavaScriptNodeError } = require('@noodl/runtime/src/utils');
const guid = require('../../guid');
/*const defaultCode = "define({\n"+
@@ -372,7 +372,8 @@ var Javascript = {
internal.changedInputs
);
} catch (e) {
console.log('Error in JS node run code.', Object.getPrototypeOf(e).constructor.name + ': ' + e.message);
logJavaScriptNodeError(e);
if (this.context.editorConnection && this.context.isWarningTypeEnabled('javascriptExecution')) {
this.context.editorConnection.sendWarning(this.nodeScope.componentOwner.name, this.id, 'js-run-waring', {
showGlobally: true,