Forker/OpenNoodl
1
0
Fork 0
mirror of https://github.com/The-Low-Code-Foundation/OpenNoodl.git synced 2026-03-08 01:53:30 +01:00
Code Issues Actions Packages Projects Releases 1 Wiki Activity

docs(sprint-2): update PROGRESS-richard.md + add TS async IIFE union narrowing learning

Browse Source
This commit is contained in:
Richard Osborne
2026-02-18 20:20:49 +01:00
parent ed16302812
commit 6403341bcc
2 changed files with 59 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
dev-docs/reference/LEARNINGS.md
View File

@@ -1855,6 +1855,22 @@ grep -r "var(--theme-spacing" packages/noodl-core-ui/src --include="*.scss"
**Discovery:** Only custom overrides are stored in project metadata — never defaults. Defaults live in `DefaultTokens.ts` and are merged at load time. This keeps `project.json` lean and lets defaults be updated without migrations.
**Location:** `StyleTokensModel._store()` uses `ProjectModel.instance.setMetaData('designTokens', data)`
## TS Won't Narrow Discriminated Unions in Async IIFEs (2026-02-18)
**Context**: UBAPanel `useUBASchema` hook — `SchemaParser.parse()` returns
`ParseResult<T>` which is `{ success: true; data: T } | { success: false; errors: ParseError[] }`.
**Discovery**: TypeScript refuses to narrow this inside an `(async () => { ... })()`,
even with `const result` and an `if (result.success) {} else {}` pattern. Error:
`Property 'errors' does not exist on type '{ success: true; ... }'`.
**Fix**: In the `else` branch, cast explicitly with an inline `type FailResult = { ... }` alias.
No need for `as any` — a precise cast is fine and type-safe.
**Location**: `views/panels/UBAPanel/UBAPanel.tsx`, `useUBASchema`.
---
## STYLE-001: DesignTokenPanel/ColorsTab pre-existed (2026-02-18)
**Context:** Adding a new "Tokens" tab to the DesignTokenPanel.