Commit Graph

2 Commits

Author SHA1 Message Date
dishant-kumar-thakur
25ce812497 fix(tests): convert io tests to Jasmine matchers for Electron test runner
- Replace toHaveLength(n) with .length).toBe(n) throughout
- Remove require() call for legacyNameToPath (use ES import)
- Remove Node.js fs/os/path integration tests from FormatDetector
  (Electron renderer context doesn't support direct Node.js imports)
- All 3 test files now compile cleanly in webpack test-ci build
- Remaining 58 errors are pre-existing (Git.pull TS2339 x13,
  @noodl-viewer-cloud/execution-history TS2307 x31)
2026-02-19 01:36:12 +05:30
dishant-kumar-thakur
1e78b5e279 feat(phase-10): STRUCT-004 project format detection utility
Task: STRUCT-004
Branch: cline-dev-dishant
Cross-branch notes: none -- no shared dependencies with Richard phase 9/6 work

- ProjectFormatDetector class (injectable filesystem, fully testable)
- detect() async + detectSync() sync variants
- Detects legacy (project.json) vs v2 (nodegx.project.json + _registry.json)
- Returns { format, confidence, indicators } for transparent decision-making
- Scoring system: v2 needs score >= 2 to avoid false positives
- Errors in exists() treated as not-found (graceful degradation)
- V2_INDICATORS / LEGACY_INDICATORS sentinel constants exported
- createNodeDetector() factory for Node.js/test contexts
- Convenience methods: getFormat(), isV2(), isLegacy()
- 30 tests in tests/io/ProjectFormatDetector.test.ts
  - detect(): 12 cases (all combinations, async fs, error handling)
  - detectSync(): 4 cases (incl. throws on async fs)
  - Convenience methods: 7 cases
  - Constants: 3 cases
  - createNodeDetector() integration: 4 cases (real tmp dirs)
- Updated tests/io/index.ts to export detector tests
- Updated PROGRESS-dishant.md: STRUCT-001/002/003/004 all marked complete
2026-02-19 01:19:46 +05:30