Forker/fluxscape
1
0
Fork 0
mirror of https://github.com/fluxscape/fluxscape.git synced 2026-01-11 14:52:54 +01:00
Code Issues Actions Packages Projects Releases 1 Wiki Activity

fix: Video node attributes (#16)

Browse Source 
Fixes https://github.com/noodlapp/noodl/issues/39
This commit is contained in:
Eric Tuvesson
2024-05-09 16:49:09 +02:00
committed by GitHub
parent 68e2070c61
commit 13c92779b2
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/noodl-viewer-react/src/components/visual/Video/Video.tsx
View File

@@ -34,16 +34,14 @@ export interface CachedVideoProps {
class CachedVideo extends React.PureComponent<CachedVideoProps> { class CachedVideo extends React.PureComponent<CachedVideoProps> {
video: HTMLVideoElement; video: HTMLVideoElement;
shouldComponentUpdate(nextProps: CachedVideoProps) { componentDidUpdate() {
if (this.video) { if (this.video) {
this.video.muted = nextProps.muted; this.video.muted = this.props.muted;
this.video.loop = nextProps.loop; this.video.loop = this.props.loop;
this.video.volume = nextProps.volume; this.video.volume = this.props.volume;
this.video.autoplay = nextProps.autoplay; this.video.autoplay = this.props.autoplay;
this.video.controls = nextProps.controls; this.video.controls = this.props.controls;
} }
return true;
} }
render() { render() {