From 89ed2d602f8c29965b7969d572ce6a49e02ef4e4 Mon Sep 17 00:00:00 2001 From: Eric Tuvesson Date: Thu, 5 Sep 2024 09:59:11 +0200 Subject: [PATCH] feat: Add source maps (#63) --- .../webpack-configs/constants.js | 18 +++++++++--------- .../webpack-configs/webpack.viewer.dev.js | 10 +++++----- .../webpack-configs/webpack.viewer.prod.js | 3 ++- .../static/deploy/index.json | 3 ++- .../webpack-configs/constants.js | 18 ++++++++---------- .../webpack-configs/webpack.common.js | 2 +- .../webpack-configs/webpack.deploy.dev.js | 10 +++++----- .../webpack-configs/webpack.deploy.prod.js | 7 ++++--- .../webpack-configs/webpack.ssr.common.js | 2 +- .../webpack-configs/webpack.ssr.prod.js | 3 ++- .../webpack-configs/webpack.viewer.dev.js | 10 +++++----- .../webpack-configs/webpack.viewer.prod.js | 7 ++++--- 12 files changed, 48 insertions(+), 45 deletions(-) diff --git a/packages/noodl-viewer-cloud/webpack-configs/constants.js b/packages/noodl-viewer-cloud/webpack-configs/constants.js index bbbf34c..9123752 100644 --- a/packages/noodl-viewer-cloud/webpack-configs/constants.js +++ b/packages/noodl-viewer-cloud/webpack-configs/constants.js @@ -1,9 +1,9 @@ -const path = require('path'); - -module.exports = { - // Allows to define the output path of the files built by the viewer. - // - // For example in the CLI, we will also build this, just with a different output path. - outPath: process.env.OUT_PATH || path.resolve(__dirname, '../../noodl-editor/src/external'), - runtimeVersion: 'cloud-runtime-' + require('../package.json').version.replaceAll('.', '-') -}; +const path = require('path'); + +module.exports = { + // Allows to define the output path of the files built by the viewer. + // + // For example in the CLI, we will also build this, just with a different output path. + outPath: process.env.OUT_PATH || path.resolve(__dirname, '../../noodl-editor/src/external'), + runtimeVersion: 'cloud-runtime-' + require('../package.json').version.replaceAll('.', '-') +}; diff --git a/packages/noodl-viewer-cloud/webpack-configs/webpack.viewer.dev.js b/packages/noodl-viewer-cloud/webpack-configs/webpack.viewer.dev.js index ffc4c9e..6481f21 100644 --- a/packages/noodl-viewer-cloud/webpack-configs/webpack.viewer.dev.js +++ b/packages/noodl-viewer-cloud/webpack-configs/webpack.viewer.dev.js @@ -1,8 +1,8 @@ -const { merge } = require("webpack-merge"); -const common = require("./webpack.viewer.common.js"); +const { merge } = require('webpack-merge'); +const common = require('./webpack.viewer.common.js'); module.exports = merge(common, { - mode: "development", - devtool: "inline-source-map", - watch: true, + mode: 'development', + devtool: 'inline-source-map', + watch: true }); diff --git a/packages/noodl-viewer-cloud/webpack-configs/webpack.viewer.prod.js b/packages/noodl-viewer-cloud/webpack-configs/webpack.viewer.prod.js index 0ecaa9c..188b34c 100644 --- a/packages/noodl-viewer-cloud/webpack-configs/webpack.viewer.prod.js +++ b/packages/noodl-viewer-cloud/webpack-configs/webpack.viewer.prod.js @@ -2,5 +2,6 @@ const { merge } = require('webpack-merge'); const common = require('./webpack.viewer.common.js'); module.exports = merge(common, { - mode: 'production' + mode: 'production', + devtool: 'source-map' }); diff --git a/packages/noodl-viewer-react/static/deploy/index.json b/packages/noodl-viewer-react/static/deploy/index.json index f169aa9..66947b6 100644 --- a/packages/noodl-viewer-react/static/deploy/index.json +++ b/packages/noodl-viewer-react/static/deploy/index.json @@ -4,6 +4,7 @@ {"url":"noodl-app.png"}, {"url":"load_terminator.js"}, {"url":"noodl.deploy.js"}, + {"url":"noodl.deploy.js.map"}, {"url":"react.production.min.js"}, {"url":"react-dom.production.min.js"} -] \ No newline at end of file +] diff --git a/packages/noodl-viewer-react/webpack-configs/constants.js b/packages/noodl-viewer-react/webpack-configs/constants.js index ff65e65..542c4d5 100644 --- a/packages/noodl-viewer-react/webpack-configs/constants.js +++ b/packages/noodl-viewer-react/webpack-configs/constants.js @@ -1,10 +1,8 @@ -const path = require("path"); - -module.exports = { - // Allows to define the output path of the files built by the viewer. - // - // For example in the CLI, we will also build this, just with a different output path. - outPath: - process.env.OUT_PATH || - path.resolve(__dirname, "../../noodl-editor/src/external"), -}; +const path = require('path'); + +module.exports = { + // Allows to define the output path of the files built by the viewer. + // + // For example in the CLI, we will also build this, just with a different output path. + outPath: process.env.OUT_PATH || path.resolve(__dirname, '../../noodl-editor/src/external') +}; diff --git a/packages/noodl-viewer-react/webpack-configs/webpack.common.js b/packages/noodl-viewer-react/webpack-configs/webpack.common.js index f1bbf69..8c0d343 100644 --- a/packages/noodl-viewer-react/webpack-configs/webpack.common.js +++ b/packages/noodl-viewer-react/webpack-configs/webpack.common.js @@ -8,7 +8,7 @@ module.exports = { resolve: { extensions: ['.tsx', '.ts', '.jsx', '.js'], fallback: { - events: require.resolve('events/'), + events: require.resolve('events/') } }, module: { diff --git a/packages/noodl-viewer-react/webpack-configs/webpack.deploy.dev.js b/packages/noodl-viewer-react/webpack-configs/webpack.deploy.dev.js index 1fb86ab..b924616 100644 --- a/packages/noodl-viewer-react/webpack-configs/webpack.deploy.dev.js +++ b/packages/noodl-viewer-react/webpack-configs/webpack.deploy.dev.js @@ -1,8 +1,8 @@ -const { merge } = require("webpack-merge"); -const common = require("./webpack.deploy.common.js"); +const { merge } = require('webpack-merge'); +const common = require('./webpack.deploy.common.js'); module.exports = merge(common, { - mode: "development", - devtool: "inline-source-map", - watch: true, + mode: 'development', + devtool: 'inline-source-map', + watch: true }); diff --git a/packages/noodl-viewer-react/webpack-configs/webpack.deploy.prod.js b/packages/noodl-viewer-react/webpack-configs/webpack.deploy.prod.js index d45e340..c288680 100644 --- a/packages/noodl-viewer-react/webpack-configs/webpack.deploy.prod.js +++ b/packages/noodl-viewer-react/webpack-configs/webpack.deploy.prod.js @@ -1,6 +1,7 @@ -const { merge } = require("webpack-merge"); -const common = require("./webpack.deploy.common.js"); +const { merge } = require('webpack-merge'); +const common = require('./webpack.deploy.common.js'); module.exports = merge(common, { - mode: "production", + mode: 'production', + devtool: 'source-map' }); diff --git a/packages/noodl-viewer-react/webpack-configs/webpack.ssr.common.js b/packages/noodl-viewer-react/webpack-configs/webpack.ssr.common.js index 9634bf1..2c12b80 100644 --- a/packages/noodl-viewer-react/webpack-configs/webpack.ssr.common.js +++ b/packages/noodl-viewer-react/webpack-configs/webpack.ssr.common.js @@ -42,7 +42,7 @@ module.exports = { resolve: { extensions: ['.tsx', '.ts', '.jsx', '.js'], fallback: { - events: require.resolve('events/'), + events: require.resolve('events/') } }, module: { diff --git a/packages/noodl-viewer-react/webpack-configs/webpack.ssr.prod.js b/packages/noodl-viewer-react/webpack-configs/webpack.ssr.prod.js index f066727..212d8b9 100644 --- a/packages/noodl-viewer-react/webpack-configs/webpack.ssr.prod.js +++ b/packages/noodl-viewer-react/webpack-configs/webpack.ssr.prod.js @@ -2,5 +2,6 @@ const { merge } = require('webpack-merge'); const common = require('./webpack.ssr.common.js'); module.exports = merge(common, { - mode: 'production' + mode: 'production', + devtool: 'source-map' }); diff --git a/packages/noodl-viewer-react/webpack-configs/webpack.viewer.dev.js b/packages/noodl-viewer-react/webpack-configs/webpack.viewer.dev.js index ffc4c9e..6481f21 100644 --- a/packages/noodl-viewer-react/webpack-configs/webpack.viewer.dev.js +++ b/packages/noodl-viewer-react/webpack-configs/webpack.viewer.dev.js @@ -1,8 +1,8 @@ -const { merge } = require("webpack-merge"); -const common = require("./webpack.viewer.common.js"); +const { merge } = require('webpack-merge'); +const common = require('./webpack.viewer.common.js'); module.exports = merge(common, { - mode: "development", - devtool: "inline-source-map", - watch: true, + mode: 'development', + devtool: 'inline-source-map', + watch: true }); diff --git a/packages/noodl-viewer-react/webpack-configs/webpack.viewer.prod.js b/packages/noodl-viewer-react/webpack-configs/webpack.viewer.prod.js index 542a4d0..188b34c 100644 --- a/packages/noodl-viewer-react/webpack-configs/webpack.viewer.prod.js +++ b/packages/noodl-viewer-react/webpack-configs/webpack.viewer.prod.js @@ -1,6 +1,7 @@ -const { merge } = require("webpack-merge"); -const common = require("./webpack.viewer.common.js"); +const { merge } = require('webpack-merge'); +const common = require('./webpack.viewer.common.js'); module.exports = merge(common, { - mode: "production", + mode: 'production', + devtool: 'source-map' });