From 8c7d4faecafb5e7ca525946ec1291d32f6404fa0 Mon Sep 17 00:00:00 2001 From: Eric Tuvesson Date: Thu, 27 Jun 2024 21:16:50 +0200 Subject: [PATCH] fix(runtime): Column node added a div with empty Repeater (#45) When the Column node only had an empty Repeater child, there was an empty HTML element. --- .../src/components/visual/Columns/Columns.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/noodl-viewer-react/src/components/visual/Columns/Columns.tsx b/packages/noodl-viewer-react/src/components/visual/Columns/Columns.tsx index 81ec7bf..0a1d620 100644 --- a/packages/noodl-viewer-react/src/components/visual/Columns/Columns.tsx +++ b/packages/noodl-viewer-react/src/components/visual/Columns/Columns.tsx @@ -117,7 +117,10 @@ export function Columns(props: ColumnsProps) { // ForEachCompoent breaks the layout but is needed to send onMount/onUnmount if (!Array.isArray(props.children)) { - children = [props.children]; + // @ts-expect-error props.children.type is any + if (props.children.type !== ForEachComponent) { + children = [props.children] + } } else { children = props.children.filter((child) => child.type !== ForEachComponent); forEachComponent = props.children.find((child) => child.type === ForEachComponent);