From ac7b97994584e197e9d85cc964d52f9a4c8aa7c6 Mon Sep 17 00:00:00 2001 From: Eric Tuvesson Date: Thu, 3 Oct 2024 11:28:04 +0200 Subject: [PATCH] fix(runtime): Close Popup node with no actions causing error https://github.com/fluxscape/fluxscape/pull/78 --- packages/noodl-viewer-react/src/api/navigation.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/noodl-viewer-react/src/api/navigation.js b/packages/noodl-viewer-react/src/api/navigation.js index 7612aee..22f3675 100644 --- a/packages/noodl-viewer-react/src/api/navigation.js +++ b/packages/noodl-viewer-react/src/api/navigation.js @@ -5,9 +5,14 @@ const navigation = { async showPopup(componentPath, params) { return new Promise((resolve) => { navigation._noodlRuntime.context.showPopup(componentPath, params, { + senderNode: this.nodeScope.componentOwner, + /** + * @param {string | undefined} action + * @param {*} results + */ onClosePopup: (action, results) => { resolve({ - action: action.replace('closeAction-', ''), + action: (action || '').replace('closeAction-', ''), parameters: results }); }