From fc0d3fc0e23c799b6d629c4b2d34e94dba9d004b Mon Sep 17 00:00:00 2001
From: jump-and-jump <984292420@qq.com>
Date: Mon, 28 Apr 2025 19:39:53 +0800
Subject: [PATCH] fix: Remove useless calls during initialization (#295)

* fix: Remove useless calls during initialization

* fix: refactor search component and enhance search functionality

* fix: clean up code formatting and improve readability in Search component and global types

---------

Co-authored-by: jump-and-jump <984292420@qq.com>
Co-authored-by: L4Ph <4ranci0ne@gmail.com>
---
 src/components/Search.svelte | 100 +++++++++++++++++++++--------------
 src/global.d.ts              |  33 ++++++++++++
 2 files changed, 94 insertions(+), 39 deletions(-)

diff --git a/src/components/Search.svelte b/src/components/Search.svelte
index 584f79ef..9a93a784 100644
--- a/src/components/Search.svelte
+++ b/src/components/Search.svelte
@@ -1,13 +1,18 @@
 <script lang="ts">
+import type { SearchResult } from "@/global";
 import I18nKey from "@i18n/i18nKey";
 import { i18n } from "@i18n/translation";
 import Icon from "@iconify/svelte";
 import { url } from "@utils/url-utils.ts";
 import { onMount } from "svelte";
+
 let keywordDesktop = "";
 let keywordMobile = "";
-let result = [];
-const fakeResult = [
+let result: SearchResult[] = [];
+let isSearching = false;
+let pagefindLoaded = false;
+
+const fakeResult: SearchResult[] = [
 	{
 		url: url("/"),
 		meta: {
@@ -25,47 +30,64 @@ const fakeResult = [
 	},
 ];
 
-let search = (keyword: string, isDesktop: boolean) => {};
-
-onMount(() => {
-	search = async (keyword: string, isDesktop: boolean) => {
-		let panel = document.getElementById("search-panel");
-		if (!panel) return;
-
-		if (!keyword && isDesktop) {
-			panel.classList.add("float-panel-closed");
-			return;
-		}
-
-		let arr = [];
-		if (import.meta.env.PROD) {
-			const ret = await pagefind.search(keyword);
-			for (const item of ret.results) {
-				arr.push(await item.data());
-			}
-		} else {
-			// Mock data for non-production environment
-			// arr = JSON.parse('[{"url":"/","content":"Simple Guides for Fuwari. Cover image source: Source. This blog template is built with Astro. For the things that are not mentioned in this guide, you may find the answers in the Astro Docs. Front-matter of Posts. --- title: My First Blog Post published: 2023-09-09 description: This is the first post of my new Astro blog. image: ./cover.jpg tags: [Foo, Bar] category: Front-end draft: false ---AttributeDescription title. The title of the post. published. The date the post was published. description. A short description of the post. Displayed on index page. image. The cover image path of the post. 1. Start with http:// or https://: Use web image 2. Start with /: For image in public dir 3. With none of the prefixes: Relative to the markdown file. tags. The tags of the post. category. The category of the post. draft. If this post is still a draft, which won’t be displayed. Where to Place the Post Files. Your post files should be placed in src/content/posts/ directory. You can also create sub-directories to better organize your posts and assets. src/content/posts/ ├── post-1.md └── post-2/ ├── cover.png └── index.md.","word_count":187,"filters":{},"meta":{"title":"This Is a Fake Search Result"},"anchors":[{"element":"h2","id":"front-matter-of-posts","text":"Front-matter of Posts","location":34},{"element":"h2","id":"where-to-place-the-post-files","text":"Where to Place the Post Files","location":151}],"weighted_locations":[{"weight":10,"balanced_score":57600,"location":3}],"locations":[3],"raw_content":"Simple Guides for Fuwari. Cover image source: Source. This blog template is built with Astro. For the things that are not mentioned in this guide, you may find the answers in the Astro Docs. Front-matter of Posts. --- title: My First Blog Post published: 2023-09-09 description: This is the first post of my new Astro blog. image: ./cover.jpg tags: [Foo, Bar] category: Front-end draft: false ---AttributeDescription title. The title of the post. published. The date the post was published. description. A short description of the post. Displayed on index page. image. The cover image path of the post. 1. Start with http:// or https://: Use web image 2. Start with /: For image in public dir 3. With none of the prefixes: Relative to the markdown file. tags. The tags of the post. category. The category of the post. draft. If this post is still a draft, which won’t be displayed. Where to Place the Post Files. Your post files should be placed in src/content/posts/ directory. You can also create sub-directories to better organize your posts and assets. src/content/posts/ ├── post-1.md └── post-2/ ├── cover.png └── index.md.","raw_url":"/posts/guide/","excerpt":"Because the search cannot work in the <mark>dev</mark> environment.","sub_results":[{"title":"Simple Guides for Fuwari - Fuwari","url":"/posts/guide/","weighted_locations":[{"weight":10,"balanced_score":57600,"location":3}],"locations":[3],"excerpt":"Simple Guides for <mark>Fuwari.</mark> Cover image source: Source. This blog template is built with Astro. For the things that are not mentioned in this guide, you may find the answers"}]},{"url":"/","content":"About. This is the demo site for Fuwari. Sources of images used in this site. Unsplash. 星と少女 by Stella. Rabbit - v1.4 Showcase by Rabbit_YourMajesty.","word_count":25,"filters":{},"meta":{"title":"If You Want to Test the Search"},"anchors":[{"element":"h1","id":"about","text":"About","location":0},{"element":"h3","id":"sources-of-images-used-in-this-site","text":"Sources of images used in this site","location":8}],"weighted_locations":[{"weight":1,"balanced_score":576,"location":7}],"locations":[7],"raw_content":"About. This is the demo site for Fuwari. Sources of images used in this site. Unsplash. 星と少女 by Stella. Rabbit - v1.4 Showcase by Rabbit_YourMajesty.","raw_url":"/about/","excerpt":"Try running <mark>npm build && npm preview</mark> instead.","sub_results":[{"title":"About","url":"/about/#about","anchor":{"element":"h1","id":"about","text":"About","location":0},"weighted_locations":[{"weight":1,"balanced_score":576,"location":7}],"locations":[7],"excerpt":"About. This is the demo site for <mark>Fuwari.</mark>"}]}]')
-			arr = fakeResult;
-		}
-
-		if (!arr.length && isDesktop) {
-			panel.classList.add("float-panel-closed");
-			return;
-		}
-
-		if (isDesktop) {
-			panel.classList.remove("float-panel-closed");
-		}
-		result = arr;
-	};
-});
-
 const togglePanel = () => {
-	let panel = document.getElementById("search-panel");
+	const panel = document.getElementById("search-panel");
 	panel?.classList.toggle("float-panel-closed");
 };
 
+const setPanelVisibility = (show: boolean, isDesktop: boolean): void => {
+	const panel = document.getElementById("search-panel");
+	if (!panel || !isDesktop) return;
+
+	if (show) {
+		panel.classList.remove("float-panel-closed");
+	} else {
+		panel.classList.add("float-panel-closed");
+	}
+};
+
+const search = async (keyword: string, isDesktop: boolean): Promise<void> => {
+	if (!keyword) {
+		setPanelVisibility(false, isDesktop);
+		result = [];
+		return;
+	}
+
+	isSearching = true;
+
+	try {
+		let searchResults: SearchResult[] = [];
+
+		if (import.meta.env.PROD && pagefindLoaded) {
+			const response = await window.pagefind.search(keyword);
+			searchResults = await Promise.all(
+				response.results.map((item) => item.data()),
+			);
+		} else {
+			searchResults = fakeResult;
+		}
+
+		result = searchResults;
+		setPanelVisibility(result.length > 0, isDesktop);
+	} catch (error) {
+		console.error("Search error:", error);
+		result = [];
+		setPanelVisibility(false, isDesktop);
+	} finally {
+		isSearching = false;
+	}
+};
+
+onMount(async () => {
+	pagefindLoaded = typeof window !== "undefined" && "pagefind" in window;
+
+	if (import.meta.env.DEV) {
+		console.log(
+			"Pagefind is not available in development mode. Using mock data.",
+		);
+	}
+});
+
 $: search(keywordDesktop, true);
 $: search(keywordMobile, false);
 </script>
diff --git a/src/global.d.ts b/src/global.d.ts
index b51df520..8d4042be 100644
--- a/src/global.d.ts
+++ b/src/global.d.ts
@@ -4,5 +4,38 @@ declare global {
 	interface Window {
 		// type from '@swup/astro' is incorrect
 		swup: AstroIntegration;
+		pagefind: {
+			search: (query: string) => Promise<{
+				results: Array<{
+					data: () => Promise<SearchResult>;
+				}>;
+			}>;
+		};
 	}
 }
+
+interface SearchResult {
+	url: string;
+	meta: {
+		title: string;
+	};
+	excerpt: string;
+	content?: string;
+	word_count?: number;
+	filters?: Record<string, unknown>;
+	anchors?: Array<{
+		element: string;
+		id: string;
+		text: string;
+		location: number;
+	}>;
+	weighted_locations?: Array<{
+		weight: number;
+		balanced_score: number;
+		location: number;
+	}>;
+	locations?: number[];
+	raw_content?: string;
+	raw_url?: string;
+	sub_results?: SearchResult[];
+}